From 610d2a97acdccf161cadf121eb3bc5433ffe2c57 Mon Sep 17 00:00:00 2001 From: Sam Hocevar Date: Mon, 3 Oct 2016 21:58:03 +0200 Subject: [PATCH] lua: remove LuaLoader::Find() helper This has proved unreliable because coroutines create whole new environments, so one of the only ways to store user data and access it even from coroutines is to use lua_setglobal(). --- src/lolua/baselua.cpp | 9 --------- src/lolua/baselua.h | 1 - 2 files changed, 10 deletions(-) diff --git a/src/lolua/baselua.cpp b/src/lolua/baselua.cpp index 6021e46d..e61679bc 100644 --- a/src/lolua/baselua.cpp +++ b/src/lolua/baselua.cpp @@ -133,15 +133,6 @@ void Loader::Release(LuaState* l, Lolua::Loader* loader) } } -Lolua::Loader *LuaLoader::Find(LuaState* l) -{ - for (int i = 0; i < g_loaders.count(); ++i) - if (g_loaders[i].m1 == l) - return g_loaders[i].m2; - - return nullptr; -} - //Store lua object -------------------------------------------------------- void Loader::StoreObject(LuaState* l, Object* obj) { diff --git a/src/lolua/baselua.h b/src/lolua/baselua.h index 7a805b82..2774423d 100644 --- a/src/lolua/baselua.h +++ b/src/lolua/baselua.h @@ -995,7 +995,6 @@ public: protected: LuaState* GetLuaState(); static void Store(LuaState* l, Loader* loader); - static Loader *Find(LuaState* l); static void Release(LuaState* l, Loader* loader); static void StoreObject(LuaState* l, Object* obj); //Virtual Store lua object ------------------------------------------------